Support column split in gpu hist updater #9384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trivialfis I'm working on enabling column-split with the gpu hist tree method. Only added some tests here, but they seem to hang on some cuda calls. Any idea on how to debug this? Do you see anything obviously wrong? |
|
@rongou GPU doesn't support multi-target yet. |
rongou
changed the title
|
@trivialfis I think this is finally working. Please take a look. Thanks! |
trivialfis
approved these changes
Aug 30, 2023
Yes probably should create a tutorial. |
trivialfis
approved these changes
Aug 31, 2023
|
For some reason, this PR has optimized the GPU hist with the Higgs dataset for about 20 percent improvement, tested with both RTX8000 and 4070 ti super. |
|
NVM, git bisect is incorrect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.