[coll] Implement a new tracker and a communicator. #9650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The new tracker and communicators communicates through the use of JSON documents. Along with which, communicators are aware of each others.
|
cc @rongou |
|
Wouldn't JSON be pretty slow, especially for large amount of data? Have you done any early benchmarking to compare it to the existing implementation? |
|
cc @rongou the JSON is only used for communication between a worker and the tracker for things like initialization, not used for actual data transfer like |
rongou
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new tracker and communicators communicates through the use of JSON documents. Along with which, communicators are aware of each others.