More in-memory input support for column split #9685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rongou
changed the title
trivialfis
reviewed
Oct 19, 2023
tests/python/test_with_arrow.py
Outdated
| @@ -101,6 +100,7 @@ def test_arrow_survival(self): | |||
| np.testing.assert_equal(y_np_low, y_lower_bound.to_pandas().values) | |||
|
|
|||
|
|
|||
| @pytest.mark.skipif(sys.platform == "win32", reason="does not run on windows") | |||
There was a problem hiding this comment.
Consider creating a function in python_package/xgboost/testing/__init__.py as def is_win.
| @@ -943,12 +944,17 @@ def project_root(path: str) -> str: | |||
|
|
|||
|
|
|||
| def run_with_rabit(world_size: int, test_fn: Callable) -> None: | |||
| tracker = RabitTracker(host_ip="127.0.0.1", n_workers=world_size) | |||
| tracker.start(world_size) | |||
| exception_queue: queue.Queue = queue.Queue() | |||
There was a problem hiding this comment.
Do we need a lock here? Or GIL is handling it?
There was a problem hiding this comment.
Queue itself is synchronized. https://docs.python.org/3/library/queue.html
tests/python/test_with_pandas.py
Outdated
| @pytest.mark.skipif(sys.platform == "win32", reason="does not run on windows") | ||
| class TestPandasColumnSplit: | ||
| @staticmethod | ||
| def verify_pandas(): |
There was a problem hiding this comment.
Any chance we can reuse the pandas test instead of copying the code?
trivialfis
approved these changes
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_dmatrix.pyandtest_with_pandas.pywithblack