[R] Move all DMatrix fields to function arguments #9862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fantastic! No doubts anymore if its "weight" or "weights" etc.! |
trivialfis
reviewed
Dec 8, 2023
| base_margin = NULL, | ||
| missing = NA, | ||
| silent = FALSE, | ||
| feature_names = colnames(data), |
There was a problem hiding this comment.
Nice, didn't know R supports this type of self-referencing parameter.
| } | ||
| if (name == "feature_name" || name == "feature_type") { | ||
| if (name == "nrow") { |
There was a problem hiding this comment.
Is this useful in practice? We have dim.xgb.DMatrix exported.
There was a problem hiding this comment.
Then I guess it's not really a must-have.
trivialfis
approved these changes
Dec 9, 2023
trivialfis
reviewed
Dec 11, 2023
| @@ -44,7 +71,6 @@ xgb.DMatrix <- function(data, info = list(), missing = NA, silent = FALSE, nthre | |||
| handle <- .Call(XGDMatrixCreateFromFile_R, data, as.integer(silent)) | |||
| } else if (is.matrix(data)) { | |||
| handle <- .Call(XGDMatrixCreateFromMat_R, data, missing, as.integer(NVL(nthread, -1))) | |||
| cnames <- colnames(data) | |||
There was a problem hiding this comment.
I will add this back in #9828 .
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #9810
This PR switches the DMatrix constructor to have all the possible inputs that it accepts as parameters in the function, like the python class for DMatrix does. The docs were all copied from the python DMatrix class.
I've purposefully left out all the parameters related to categorical features as that's still a work in progress from what I understand.