Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct name of function for setting data frames in proxy dmatrix #9905

Merged
merged 1 commit into from
Dec 20, 2023

Conversation

david-cortes
Copy link
Contributor

In a previous PR: #9828

A C function XGProxyDMatrixSetDataColumnar was introduced, but what was added to the public C header was instead XGProxyDMatrixSetDataCudaColumnar, which overlaps with a previous function name.

This PR renames it to match with the function which was introduced in the PR.

@david-cortes
Copy link
Contributor Author

Failing job seems unrelated:

Error: Unexpected HTTP status code '500' when retrieving versions from 'https://static.azul.com/zulu/bin/'.

@trivialfis
Copy link
Member

Those are different functions, I will take a look.

@trivialfis trivialfis merged commit 252e018 into dmlc:master Dec 20, 2023
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants