Save model in ubj as the default. #9947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trivialfis
force-pushed
the
default-ubj
branch
from
2140295 to
0c5ccd0
Compare
|
@wbo4958 Would be great if you could help take a look when you are available. |
trivialfis
changed the title
trivialfis
commented
Jan 4, 2024
| @@ -668,8 +668,7 @@ def weight_margin(draw: Callable) -> TestDataset: | |||
|
|
|||
| # A strategy for drawing from a set of example datasets. May add random weights to the | |||
| # dataset | |||
| @memory.cache | |||
There was a problem hiding this comment.
Removed since the composite strategy cannot be pickled. joblib has been issuing warnings for a while.
| @@ -1313,10 +1313,8 @@ XGB_DLL int XGBoosterLoadModel(BoosterHandle handle, const char* fname) { | |||
|
|
|||
| namespace { | |||
| void WarnOldModel() { | |||
| if (XGBOOST_VER_MAJOR >= 2) { | |||
There was a problem hiding this comment.
The version is lowered since we have released an extra 1.7 release. The original plan was to go from 1.6 to 2.0
wbo4958
reviewed
Jan 5, 2024
There was a problem hiding this comment.
Still need to update the comments of https://github.com/dmlc/xgboost/blob/master/jvm-packages/xgboost4j-spark/src/main/scala/org/apache/spark/ml/util/XGBoostReadWrite.scala#L34
|
Otherwise, LGTM. |
|
Thank you for sharing! |
RAMitchell
approved these changes
Jan 5, 2024
|
Still need to refresh the document, will open another PR once the R package is sorted out. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #7547 .
verbosityin tests so that I can capture warnings.