Support linux #324
Open
Support linux #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
got v12: https://github.com/sindresorhus/got/releases/tag/v12.0.0 introduced some breaking changes, including the package becoming pure ESM. For compatibility, the package has been rolled back to v11.
The mac64 edgedriver works on apple silicon, so it should also be supported.
|
Can this be merged by any chance? @saifahn @dmlemeshko @bingenito |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Builds on #323 and #322.
Resolves #301.
I tested it manually in a docker container, but I wonder if having some GitHub Actions or something would be a good idea 🤔
Any feedback, changes, comments would be appreciated (on all of the PRs)!