Add support to GPUs in TaskChain spec #10805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins results:
|
validate top level GPU in TaskChain
TaskChain unit tests for GPU
|
Jenkins results:
|
|
Basic tests went fine in my VM. @todor-ivanov feel free to leave any questions and/or your review. I will tackle the StepChain use case tomorrow, so I can fix whatever is left from this one. Thanks! |
| @@ -1217,6 +1217,9 @@ def getChainCreateArgs(firstTask=False, generator=False): | |||
| 'Memory': {'default': None, 'null': True, 'type': float, 'validate': lambda x: x > 0}, | |||
| 'Multicore': {'default': 0, 'type': int, 'validate': lambda x: x > 0}, | |||
| 'PrepID': {'default': None, 'null': True, 'optional': True, 'type': str}, | |||
| "RequiresGPU": {"default": "forbidden", | |||
There was a problem hiding this comment.
I hope these few lines do not overlap with the some of the previous PR. Otherwise this may cause some conflicts.
todor-ivanov
approved these changes
Sep 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10400
Status
ready
Description
As a follow up of: #10799
this PR enabled GPU support in the TaskChain spec, thus, supporting it inside each Task definition as well.
Note that for
TaskChainworkflows, there is the same default values as those for top level, thus:and the top level arguments will have
Is it backward compatible (if not, which system it affects?)
YES (new arguments were made optional)
Related PRs
Complement to: #10799
External dependencies / deployment changes
None