Destroy Views when no longer needed

src/vpoller/agent.py

@@ -82,6 +82,8 @@ def _discover_objects(self, properties, obj_type):
         except Exception as e:
             return { 'success': 1, 'msg': 'Cannot collect properties: %s' % e }
 
+        view_ref.DestroyView()
+
         result = {
             'success': 0,
             'msg': 'Successfully discovered objects',
@@ -144,6 +146,8 @@ def _get_object_properties(self, properties, obj_type, obj_property_name, obj_pr
         except Exception as e:
             return { 'success': 1, 'msg': 'Cannot collect properties: %s' % e }
 
+        view_ref.DestroyView()
+
         result = {
             'success': 0,
             'msg': 'Successfully retrieved object properties',
@@ -201,6 +205,8 @@ def _object_datastore_get(self, obj_type, name):
             path_set=['name', 'info.url']
         )
 
+        view_ref.DestroyView()
+
         r = {
             'success': 0,
             'msg': 'Successfully discovered objects',
@@ -390,6 +396,8 @@ def net_host_get(self, msg):
             path_set=['name']
         )
 
+        view_ref.DestroyView()
+
         r = {
             'success': 0,
             'msg': 'Successfully discovered objects',
@@ -442,6 +450,8 @@ def net_vm_get(self, msg):
             path_set=['name']
         )
 
+        view_ref.DestroyView()
+
         r = {
             'success': 0,
             'msg': 'Successfully discovered objects',
@@ -756,6 +766,8 @@ def host_vm_get(self, msg):
             path_set=['name']
         )
 
+        view_ref.DestroyView()
+
         r = {
             'success': 0,
             'msg': 'Successfully discovered objects',
@@ -808,6 +820,8 @@ def host_net_get(self, msg):
             path_set=['name']
         )
 
+        view_ref.DestroyView()
+
         r = {
             'success': 0,
             'msg': 'Successfully discovered objects',
@@ -1053,6 +1067,8 @@ def vm_net_get(self, msg):
             path_set=['name']
         )
 
+        view_ref.DestroyView()
+
         r = {
             'success': 0,
             'msg': 'Successfully discovered objects',

src/vpoller/connector.py

@@ -218,6 +218,8 @@ def get_container_view(self, obj_type, container=None):
         """
         Get a vSphere Container View reference to all objects of type 'obj_type'
 
+        It is up to the caller to take care of destroying the View when no longer needed.
+
         Args:
             obj_type (list): A list of managed object types
 
@@ -242,6 +244,8 @@ def get_list_view(self, obj):
         """
         Get a vSphere List View reference 
 
+        It is up to the caller to take care of destroying the View when no longer needed.
+
         Args:
             obj (list): A list of managed object to include in the List View
 
@@ -277,6 +281,8 @@ def get_object_by_property(self, property_name, property_value, obj_type):
             include_mors=True
         )
 
+        view_ref.DestroyView()
+
         for each_obj in props:
             if each_obj[property_name] == property_value:
                 return each_obj['obj']