Use dart based sass in Portal and Stories #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e029ded:
|
tujoworker
force-pushed
the
fix/use-dart-sass
branch
from
0626b77
to
e029ded
Compare
Gatsby Cloud Build ReportDNB Eufemia Portal 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 8m PerformanceLighthouse report
|
dinarosv
approved these changes
Oct 29, 2021
|
🎉 This PR is included in version 9.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will use dart based sass for both the portal and stories.
For the build process will still use
node-sassbecause of the usage ofnode-sass-once-importerand the lack of an easy replacement – as of now.The second reason why we still use
node-sassare the usage of sass in jest tests.Because we need the jest testEnvironment to be jsdom (
testEnvironment: 'jsdom') the dart based sass can't find the given file.There is an unsolved issue about that, and none of the solutions did work out.