[FE3] pwa setting #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JaeMeDev
commented
Aug 10, 2022
JaeMeDev
commented
- next-pwa를 통한 pwa 설정
|
Codecov Report
@@ Coverage Diff @@
## main #21 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 63 63
Branches 3 3
=========================================
Hits 63 63 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
saseungmin
reviewed
Aug 10, 2022
next.config.js
Outdated
Comment on lines
34
to
47
| module.exports = isProd ? withPlugins( | ||
| [ | ||
| [ | ||
| withPWA, | ||
| { | ||
| pwa: { | ||
| dest: 'public', | ||
| runtimeCaching, | ||
| }, | ||
| }, | ||
| ], | ||
| ], | ||
| nextConfig, | ||
| ) : nextConfig; |
There was a problem hiding this comment.
withPWA에 disable 옵션이 있어용
다음과 같이 적용하면 dev환경에서는 PWA가 적용되지 않아요
module.exports = withPlugins([
[withPWA, {
pwa: {
dest: 'public',
maximumFileSizeToCacheInBytes: 7000000,
disable: process.env.NODE_ENV === 'development',
runtimeCaching,
},
}],
], nextConfig);There was a problem hiding this comment.
수정했습니다. 원래 disable 옵션 줘서 작업했는데 develop환경에서 pwa가 오작동 하는 것 같아 빼고 저렇게 작업했었습니다. (결국엔 전부 오작동 하고 있었지만...)
알아보니 next-pwa@5.5.5에서 pwa 옵션이 빠져서 오작동하는 문제였고 next-pwa@5.5.4로 버전 변경해서 문제해결했습니다.
package.json
Outdated
| @@ -93,6 +94,7 @@ | |||
| "jest-environment-jsdom": "^28.1.1", | |||
| "jest-plugin-context": "^2.9.0", | |||
| "lint-staged": "^13.0.3", | |||
| "next-compose-plugins": "^2.2.1", | |||
There was a problem hiding this comment.
next-compose-plugins는 런타임에도 필요한 플러그인이기 때문에 devDependencies가 아니라 dependencies로 설치해야합니다. 대부분의 플러그인 사용은 런타임에 필요해용
src/pages/_document.page.tsx
Outdated
| Head, Html, Main, NextScript, | ||
| } from 'next/document'; | ||
|
|
||
| export default class MyDocument extends Document { |
There was a problem hiding this comment.
default는 이렇게 하는게 좋아보여요!
export default MyDocument;
JaeMeDev
force-pushed
the
feature/FE-3
branch
2 times, most recently
from
42f8943 to
f924561
Compare
JaeMeDev
force-pushed
the
feature/FE-3
branch
3 times, most recently
from
1001103 to
178d88f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.