Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue183 #184

Merged
merged 7 commits into from
Jun 21, 2021
Merged

Issue183 #184

merged 7 commits into from
Jun 21, 2021

Conversation

vixie
Copy link
Collaborator

@vixie vixie commented Jun 20, 2021

closes #183

@vixie vixie requested a review from djw1149 June 20, 2021 18:29
djw1149
djw1149 requested changes Jun 20, 2021
View reviewed changes
Copy link
Collaborator

@djw1149 djw1149 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't like the hidden -0 command line option. Is it debug code left in the commit?

@vixie
Copy link
Collaborator Author

vixie commented Jun 21, 2021

how about now?

@djw1149
Copy link
Collaborator

djw1149 commented Jun 21, 2021

Ok. Fine to merge

@vixie vixie merged commit 8522672 into master Jun 21, 2021
@vixie vixie deleted the issue183 branch June 21, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djw1149 djw1149 djw1149 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rdata of "." causes "dnsdbq: sort.c:254: sortable_dnsname: Assertion `new_size != 0' failed."
2 participants
@vixie @djw1149