Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SPF/TXT multipart handling #150

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Conversation

weppos
Copy link
Member

@weppos weppos commented Nov 8, 2023

This PR introduces the multi-part SPF/TXT handling. The underlying RR types are already defined so that the value is a list, but we currently ignore it and we attempt to parse/split the incoming value.

This is related to https://github.com/dnsimple/dnsimple-business/issues/1765, in particular to issues related to the TXT implementation. The current implementation is designed to prefer the parts over the single value, whenever the JSON contains a valid element with the expected value.

Here's some examples.

1. TXT: Both txt and txts exists, txts is used

dig -p 8053 @127.0.0.1 txt2d.multipart.example TXT

txt2d.multipart.example. 120	IN	TXT	"string c" "string d"

@weppos weppos self-assigned this Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant