Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace jsx with built-in json module #163

Merged
merged 4 commits into from
Dec 19, 2024
Merged

Replace jsx with built-in json module #163

merged 4 commits into from
Dec 19, 2024

Conversation

whatyouhide
Copy link
Contributor

@whatyouhide whatyouhide commented Oct 23, 2024 •
edited
Loading

Needs to drop support for OTP 26 or earlier.

@whatyouhide whatyouhide self-assigned this Oct 23, 2024
@weppos weppos changed the title Replace jsx with built-in JSON Replace jsx with built-in json module Oct 28, 2024
@weppos weppos removed their request for review October 28, 2024 13:34
@weppos weppos changed the title Replace jsx with built-in json module Replace jsx with built-in json module Oct 28, 2024
@weppos
Copy link
Member

weppos commented Nov 21, 2024

@m0rcq @DXTimer as the current build work is ending today, are you able by next Monday to provide a review please.

DXTimer
DXTimer approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@DXTimer DXTimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was able to verify the changes, this is good to go.

@whatyouhide
Copy link
Contributor Author

I’m merging this since I got y'all's approvals.

@whatyouhide whatyouhide merged commit 08f1a8a into main Dec 19, 2024
2 checks passed
@whatyouhide whatyouhide deleted the al/json branch December 19, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DXTimer DXTimer DXTimer approved these changes

@san983 san983 san983 approved these changes

@m0rcq m0rcq m0rcq approved these changes

Assignees

@whatyouhide whatyouhide

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@whatyouhide @weppos @m0rcq @san983 @DXTimer