Fix equipment set filter on retail WoW #129
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
little bit of a style change but merged here: 8b91a76 thanks! |
|
Eh, it's more than a style-change tho? I really didn't like those repeated version checks, which was the entire reason for extracting the |
|
@Elberet I guess maybe not really "style" but its functionly the same. Idk. To me I didn't like how it looked. Also the way you had it it still uses version checks so, doesnt really add more function calls? Thats why I thought of it as more of a style change. Idk, if you think I should change it back let me know, doesnt seem to make a difference to me. |
|
Nah, it's fine. In this context, it's mostly an irrelevant micro-optimization, and keeping the code readable is probably more desirable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #127
On retail, the
UnpackItemLocationAPI function still returns a flag for items in void storage.