Skip to content
This repository has been archived by the owner on Oct 13, 2023. It is now read-only.

[17.06] Move the hashing of files to its own target #164

Conversation

seemethere
Copy link
Contributor

@seemethere seemethere commented Aug 2, 2017

Don't really know how this commit didn't fully get in but this basically removes the $(HASH_CMD) from the basic static targets.

Without this the cross-win target for components/packaging/static/Makefile will fail.

Cherry-picked from: docker/docker-ce-packaging#1

git cherry-pick -x -s -Xsubtree="components/packaging" 533a843393bd7c3674074ec9af73c8e666fc7484

Signed-off-by: Eli Uriegas eli.uriegas@docker.com
(cherry picked from commit 533a843)
Signed-off-by: Eli Uriegas eli.uriegas@docker.com

So we can use it at will

Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
(cherry picked from commit 533a843)
Signed-off-by: Eli Uriegas <eli.uriegas@docker.com>
@seemethere
Copy link
Contributor Author

CC @andrewhsu

@andrewhsu andrewhsu added this to the 17.06.1 milestone Aug 2, 2017
Copy link
Contributor

@andrewhsu andrewhsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewhsu andrewhsu merged commit 8738f29 into docker-archive:17.06 Aug 2, 2017
@seemethere seemethere deleted the cherry_pick_static_file_hashing_commits branch August 2, 2017 21:34
tophj-ibm pushed a commit to tophj-ibm/docker-ce that referenced this pull request Aug 29, 2017
Clarify ability to attach multiple times
Upstream-commit: 9f00ec085f2b9a508e8aaaa6067b2a088d70c5db
Component: cli
docker-jenkins pushed a commit that referenced this pull request Aug 24, 2018
[18.09] added RestartSec
Upstream-commit: e551ce432933cc841103688852390768c2eeda0d
Component: packaging
docker-jenkins pushed a commit that referenced this pull request Mar 6, 2019
[18.09 backport] set bigger grpc limit for GetConfigs api
Upstream-commit: ad59cba5a02bf22f4e8e56c5e9c02476d31f2ced
Component: engine
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants