Fix behavior around BASHBREW_LIBRARY in GHA
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See https://github.com/docker-library/docs/blob/bb2429cba3b5a788647ad3c84d6c183d7e1afdd9/.template-helpers/arches.sh#L11-L14 for a pre-existing example of this precedent. |
This script needs/uses a custom `BASHBREW_LIBRARY` directory, but it stores that value in the exported environment slightly too soon such that `generate-stackbrew-library.sh` picks it up (and shouldn't be). We often use "`BASHBREW_LIBRARY` is unset (or empty)" as a conditional for whether to fall back to using "https://github.com/docker-library/official-images/raw/HEAD/library/" as an explicit prefix for querying "source of truth" values for things like supported parent architectures. These two things collided in docker-library/buildpack-deps@cc2dc88 (and similar commits) because the script saw `BASHBREW_LIBRARY` set, trusted it, but then fails to find the parent image. This is the cleanest place to fix this such that `generate-stackbrew-library.sh` can take `BASHBREW_LIBRARY` from the provided environment instead of using our generated value.
tianon
force-pushed
the
BASHBREW_LIBRARY
branch
from
fffa4d9 to
d64a9e8
Compare
yosifkit
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This script needs/uses a custom
BASHBREW_LIBRARYdirectory, but it stores that value in the exported environment slightly too soon such thatgenerate-stackbrew-library.shpicks it up (and shouldn't be).We often use "
BASHBREW_LIBRARYis unset (or empty)" as a conditional for whether to fall back to using "https://github.com/docker-library/official-images/raw/HEAD/library/" as an explicit prefix for querying "source of truth" values for things like supported parent architectures.These two things collided in docker-library/buildpack-deps@cc2dc88 (and similar commits) because the script saw
BASHBREW_LIBRARYset, trusted it, but then fails to find the parent image.This is the cleanest place to fix this such that
generate-stackbrew-library.shcan takeBASHBREW_LIBRARYfrom the provided environment instead of using our generated value.