Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add section about Ruby image assumptions #1221

Merged
merged 1 commit into from
May 14, 2018

Conversation

tianon
Copy link
Member

@tianon tianon commented May 11, 2018

Closes docker-library/ruby#129
Closes docker-library/ruby#83
Closes docker-library/ruby#191
Closes docker-library/ruby#188

I've verified that this recommendation works by taking the Dockerfile provided in docker-library/ruby#188 (comment) and adding ENV BUNDLE_BIN= (to unset BUNDLE_BIN):

FROM ruby:2.4

ENV BUNDLE_BIN=

RUN set -ex;\
    git clone https://github.com/jwt/ruby-jwt.git;\
    cd ruby-jwt;\
    bundle install;\
    cd ..;\
    git clone https://github.com/janlelis/clipboard.git;\
    cd clipboard;\
    bundle install;\
    ls -la /clipboard/Gemfile.lock
$ docker build --pull .
Sending build context to Docker daemon  2.048kB
...
Step 2/3 : ENV BUNDLE_BIN=
...
Step 3/3 : RUN set -ex;    git clone https://github.com/jwt/ruby-jwt.git;    cd ruby-jwt;    bundle install;    cd ..;    git clone https://github.com/janlelis/clipboard.git;    cd clipboard;    bundle install;    ls -la /clipboard/Gemfile.lock
...
+ ls -la /clipboard/Gemfile.lock
-rw-r--r-- 1 root root 661 May 11 20:54 /clipboard/Gemfile.lock
Removing intermediate container fbd54d26c43b
 ---> 399ec4e9f562
Successfully built 399ec4e9f562

@yosifkit yosifkit merged commit bef45c8 into docker-library:master May 14, 2018
@yosifkit yosifkit deleted the ruby-quirks branch May 14, 2018 19:24
EricHripko pushed a commit to EricHripko/eric.hripko.com that referenced this pull request Feb 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants