Move Ghost 2 over to Node.js 10 #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tianon as far as I know Ghost 1.x is still actively supported (I haven't heard anything to the contrary). However I'd agree with keeping Ghost 1.x using Node 8 for now. |
acburdine
approved these changes
Mar 26, 2019
|
Awesome, thanks for confirming |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 26, 2019
Changes: - docker-library/ghost@f0acc26: Merge pull request docker-library/ghost#179 from infosiftr/node-10 - docker-library/ghost@b20772b: Move Ghost 2 over to Node.js 10
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 26, 2019
Changes: - docker-library/ghost@03a0bb9: Update to 2.19.0, ghost-cli 1.9.9 - docker-library/ghost@f0acc26: Merge pull request docker-library/ghost#179 from infosiftr/node-10 - docker-library/ghost@b20772b: Move Ghost 2 over to Node.js 10
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 27, 2019
Changes: - docker-library/ghost@09d1948: Update to 2.19.1, ghost-cli 1.9.9 - docker-library/ghost@03a0bb9: Update to 2.19.0, ghost-cli 1.9.9 - docker-library/ghost@f0acc26: Merge pull request docker-library/ghost#179 from infosiftr/node-10 - docker-library/ghost@b20772b: Move Ghost 2 over to Node.js 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #178
I don't think Ghost 1 supports/recommends Node.js 10 (yet?) -- I was kind of wondering if Ghost 1 is still actively supported upstream? (last release appears to be 1.25.7 on Feb 7, which is still plausible for being actively supported)