Fix the cache broken by the ociref changes #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
One part of the code was storing keys in our `sync.Map` as a `string` and the other as a `Reference` so they never matched. 😭 If `sync.Map` had been written in the brave new world of Go generics, we'd have a compilation error to help us catch this. 🤦 We *could* get clever with something like a `--network=none` container that forces `builds` to use the cache, but it's a bit complex to set up correctly (so instead I think we should wait for the eventual `sync/v2` upstream Go package or fork/write/switch to a separate "generic" / type-safe `sync.Map` package in the future).
yosifkit
approved these changes
Mar 25, 2024
|
😂 |
|
Even better (more fair "most of the runs" comparison):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by #32 😇
One part of the code was storing keys in our
sync.Mapas astringand the other as aReferenceso they never matched. 😭If
sync.Maphad been written in the brave new world of Go generics, we'd have a compilation error to help us catch this. 🤦We could get clever with something like a
--network=nonecontainer that forcesbuildsto use the cache, but it's a bit complex to set up correctly (so instead I think we should wait for the eventualsync/v2upstream Go package or fork/write/switch to a separate "generic" / type-safesync.Mappackage in the future).See also golang/go#47657, golang/go#48287
😇