Update versions.sh to filter targets correctly for pre-releases
#705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is relevant right now because 8.0.0-rc15 adds support for ubuntu 24.04 (noble), but 7.0 doesn't support it yet, so it's impossible to install the `noble` pre-release builds. This fixes the calculation of which base image to use by cross-referencing this case. While doing so, I centralized more of the logic for when/where we need that backwards version so we don't have to do the same weird calculations in multiple places / languages (with a new `dockerNeedsVersion` field in `versions.json`). With this change, I was able to run `./versions.sh` and successfully build 8.0.0-rc15.
yosifkit
approved these changes
Aug 1, 2024
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Aug 1, 2024
Changes: - docker-library/mongo@9895a97: Update 8.0-rc to 8.0.0-rc15 - docker-library/mongo@3ad9e30: Merge pull request docker-library/mongo#705 from infosiftr/versions-filter-targets - docker-library/mongo@bcb585e: Update `versions.sh` to filter targets correctly for pre-releases - docker-library/mongo@290c08f: Add more base distribution mappings
|
😭 I'm both sad and happy about mongodb-js/mongosh#2094 (I've tested and was able to swap from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is relevant right now because 8.0.0-rc15 adds support for ubuntu 24.04 (noble), but 7.0 doesn't support it yet, so it's impossible to install the
noblepre-release builds.This fixes the calculation of which base image to use by cross-referencing this case. While doing so, I centralized more of the logic for when/where we need that backwards version so we don't have to do the same weird calculations in multiple places / languages (with a new
dockerNeedsVersionfield inversions.json).With this change, I was able to run
./versions.shand successfully build 8.0.0-rc15.