Update Backdrop CMS to version 1.12.3

[jenlampton]

Update Backdrop CMS to version 1.12.2

now Update Backdrop CMS to version 1.12.3

[yosifkit]

Just noting that the build failure is indicating that the images are FROM an outdated and unsupported version of PHP. The 5 series is end of life and as such the php:5.6 images will no longer be receiving updates. They were first removed just after 5.6 EOL date (#5250), then added back for a final security fix (#5285) and removed again shortly after (#5387). It seems unlikely to me that there will be another security fix.

What this means for the Backdrop images is that the current php:5.6-apache and php:5.6-fpm images will not change. When the base debian:stretch-slim image is updated, the php:5.6 images will not be rebuilt to include those updates. So if there is a major security vulnerability in the future like CVE-2019-3462, then they would not have that update.

I recommend moving to a supported version as soon as possible. Going by the supported versions list from php.net, I would say 7.2 is a good target, since it still has about 2 years of updates left, but 7.3 might be even better depending on your needs. You are also welcome to have multiple variations from different versions of php (like we do for wordpress).

[yosifkit]

@jenlampton, friendly ping. Would you like to address the old PHP version or will that be in the next bump PR?

[jenlampton]

@yosifkit I'll address it and push an update. I will try to get it tomorrow if not later today.

[yosifkit]

No worries on rushing it. When I see the push this weekend, I'll try to get this PR merged. Thanks!

[jenlampton]

@serundeputy I may need your help with this. I don't see anything in our repo relating to PHP versions, so I'm not sure what needs to be changed. Any ideas?

[serundeputy]

@jenlampton

• https://github.com/backdrop-ops/backdrop-docker/blob/master/1/apache/Dockerfile#L2
• https://github.com/backdrop-ops/backdrop-docker/blob/master/1/fpm/Dockerfile#L2

[jenlampton]

Thanks Geoff, not sure how grep missed those... :)

[jenlampton]

We've got a security release coming out today, so updating issue title to reflect latest version.

[jenlampton]

PR updated, testing now @yosifkit

[yosifkit]

Thanks! LGTM.

Diff:

diff --git a/backdrop_fpm/Dockerfile b/backdrop_fpm/Dockerfile
index c10a1ac..9f75f8f 100644
--- a/backdrop_fpm/Dockerfile
+++ b/backdrop_fpm/Dockerfile
@@ -1,5 +1,5 @@
 # from https://backdropcms.org/requirements
-FROM php:5.6-fpm
+FROM php:7.2-fpm
 
 # install the PHP extensions we need
 RUN apt-get update && apt-get install -y libpng-dev libjpeg-dev libpq-dev \
@@ -10,8 +10,8 @@ RUN apt-get update && apt-get install -y libpng-dev libjpeg-dev libpq-dev \
 WORKDIR /var/www/html
 
 # https://github.com/backdrop/backdrop/releases
-ENV BACKDROP_VERSION 1.11.3
-ENV BACKDROP_MD5 548333a6eec104af1ff6f19cd73791e4
+ENV BACKDROP_VERSION 1.12.3
+ENV BACKDROP_MD5 bdb98834654f09d02abfa548e63bbcda
 
 RUN curl -fSL "https://github.com/backdrop/backdrop/archive/${BACKDROP_VERSION}.tar.gz" -o backdrop.tar.gz \
 	&& echo "${BACKDROP_MD5} *backdrop.tar.gz" | md5sum -c - \
diff --git a/backdrop_latest/Dockerfile b/backdrop_latest/Dockerfile
index 7f7fc9a..5afc2d2 100644
--- a/backdrop_latest/Dockerfile
+++ b/backdrop_latest/Dockerfile
@@ -1,5 +1,5 @@
 # from https://backdropcms.org/requirements
-FROM php:5.6-apache
+FROM php:7.2-apache
 
 RUN a2enmod rewrite
 
@@ -12,8 +12,8 @@ RUN apt-get update && apt-get install -y libpng-dev libjpeg-dev libpq-dev \
 WORKDIR /var/www/html
 
 # https://github.com/backdrop/backdrop/releases
-ENV BACKDROP_VERSION 1.11.3
-ENV BACKDROP_MD5 548333a6eec104af1ff6f19cd73791e4
+ENV BACKDROP_VERSION 1.12.3
+ENV BACKDROP_MD5 bdb98834654f09d02abfa548e63bbcda
 
 RUN curl -fSL "https://github.com/backdrop/backdrop/archive/${BACKDROP_VERSION}.tar.gz" -o backdrop.tar.gz \
   && echo "${BACKDROP_MD5} *backdrop.tar.gz" | md5sum -c - \

Build test of #5424; c72b982; amd64 (backdrop):

$ bashbrew build backdrop:1.10.1
Building bashbrew/cache:7510f7ff8c6f4cb02196f5e8feeaa26b63c65be15c8ca690415b62b3cb1a9e2b (backdrop:1.10.1)
Tagging backdrop:1.10.1
Tagging backdrop:1.10
Tagging backdrop:1
Tagging backdrop:1.10.1-apache
Tagging backdrop:1.10-apache
Tagging backdrop:1-apache
Tagging backdrop:apache
Tagging backdrop:latest

$ test/run.sh backdrop:1.10.1
testing backdrop:1.10.1
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed


$ bashbrew build backdrop:1.10.1-fpm
Building bashbrew/cache:a2816d0c00b0307d80f541e1dcdafaaedaeea1f77abf3f2c00cb45fadac4fb45 (backdrop:1.10.1-fpm)
Tagging backdrop:1.10.1-fpm
Tagging backdrop:1.10-fpm
Tagging backdrop:1-fpm
Tagging backdrop:fpm

$ test/run.sh backdrop:1.10.1-fpm
testing backdrop:1.10.1-fpm
	'utc' [1/4]...passed
	'cve-2014--shellshock' [2/4]...passed
	'no-hard-coded-passwords' [3/4]...passed
	'override-cmd' [4/4]...passed

[jenlampton]

Thanks!