Add php 5.3 and 5.4 fixing the update script #1
Conversation
|
@tianon, @Moghedrin can you review? |
| && make -j"$(nproc)" \ | ||
| && make install \ | ||
| && apt-get purge -y autoconf2.13 curl \ | ||
| && apt-get autoremove -y \ |
There was a problem hiding this comment.
Can we use apt-get purge -y --auto-remove autoconf2.13 curl instead of this separate autoremove line? (I know there are other repos that ought to do this too, but this one can at least start off on the right foot.)
There was a problem hiding this comment.
Oh, we should probably purge bison and libbison-dev too, right?
There was a problem hiding this comment.
What is the difference between apt-get purge -y --auto-remove pkg and apt-get autoremove -y pkg?
Not yet sure what effect the bison removal would have. /me goes testing.
There was a problem hiding this comment.
So, apt-get purge -y --auto-remove package is the same as apt-get purge -y package && apt-get autoremove -y except it does everything in one step, and even does "purge" on the autoremoved packages instead of just the main package.
|
Other than my minor comments, LGTM cc @Moghedrin |
|
I will probably throw in PHP 5.6 as it was just released today. Should I put 5.6 as latest? |
|
Legit! If it's considered a "stable" release upstream, absolutely. :) |
|
As stable as php. http://php.net/archive/2014.php#id2014-08-28-1 |
|
http://us3.php.net/downloads.php Yep, that's "latest". :) |
|
Added one more check: @tianon, @Moghedrin |
|
LGTM, will merge. 👍 |
Add php 5.3 and 5.4 fixing the update script
Run update.sh to make the feature available.
No description provided.