Copy SSL certificate files when run as root (while they're most likely to be readable by our user) #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yosifkit
reviewed
Oct 25, 2018
3.6-rc/alpine/docker-entrypoint.sh
Outdated
| [ -n "$val" ] || continue | ||
| case "$conf" in | ||
| *_ssl_*file | ssl_*file ) | ||
| if [ -f "$val" ]; then |
There was a problem hiding this comment.
Would it make sense to only move it if the rabbitmq user does not have access?
There was a problem hiding this comment.
i.e., it could already be owned by user 999 or be accessible by a group that we are in (--group-add) or even world readable. 😲 As far as I can tell from the documentation, it shouldn't care how it can read it as long as it can (and access the directory): "have the appropriate permissions".
There was a problem hiding this comment.
Really good point -- we should verify access and throw a warning too.
…y to be readable by our user)
tianon
added a commit
to infosiftr/stackbrew
that referenced
this pull request
Oct 26, 2018
- `gcc`: 6.5.0 - `mariadb`: 5.5.62 - `openjdk`: debian `8u181-b13-2~deb9u1` - `rabbitmq`: copy SSL certificates with a warning if necessary (docker-library/rabbitmq#285) - `ruby`: bundler 1.17.1
autophagy
pushed a commit
to crate/official-images
that referenced
this pull request
Dec 12, 2018
- `gcc`: 6.5.0 - `mariadb`: 5.5.62 - `openjdk`: debian `8u181-b13-2~deb9u1` - `rabbitmq`: copy SSL certificates with a warning if necessary (docker-library/rabbitmq#285) - `ruby`: bundler 1.17.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #283
This adjusts our step-down-from-
rootcode to also copy any relevant SSL certificate files andchown/chmodthem appropriately so that our new user can read them (since the ones provided by the container user likely are difficult to provide with appropriate permissions for therabbitmquser).