Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new "bashbrew" composite action #590

Merged
merged 1 commit into from
Nov 16, 2022

Conversation

tianon
Copy link
Member

@tianon tianon commented Nov 16, 2022

See docker-library/bashbrew#57

@lukebakken this is the full fix for what you ran into over in #589 🙇

(docker-library/bashbrew#55 had a little bit of unintended breakage)

@tianon tianon merged commit 752c836 into docker-library:master Nov 16, 2022
@tianon tianon deleted the bashbrew-action branch November 16, 2022 22:34
Copy link
Collaborator

@lukebakken lukebakken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK great! So this means that go version 1.18 isn't really required?

@lukebakken
Copy link
Collaborator

@tianon if you're curious, this is the build with the compilation failure - https://github.com/docker-library/rabbitmq/actions/runs/3481840757/jobs/5823440084

@yosifkit
Copy link
Member

It is, but it is automatic via the docker-library/bashbrew@HEAD action so that we can, hopefully, update/fix in one place.

docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Nov 28, 2022
Changes:

- docker-library/rabbitmq@c9ff662: Update 3.9 to 3.9.26
- docker-library/rabbitmq@3db783a: Update 3.11 to 3.11.4
- docker-library/rabbitmq@71ae749: Update 3.10 to 3.10.12
- docker-library/rabbitmq@752c836: Merge pull request docker-library/rabbitmq#590 from infosiftr/bashbrew-action
- docker-library/rabbitmq@052dfc3: Use new "bashbrew" composite action
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants