-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PATH to use the fully generic binstubs #208
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bundler binstubs are not necessarily generic; they were until bundler 1.16 and should be fixed back, but will likely be non-generic again by default in 2.0 See rubygems/bundler#6469 (comment)
Can we include a link in the |
tianon
approved these changes
May 16, 2018
It was green before the comment addition, merging. 👍 |
This change removes |
tianon
added a commit
to infosiftr/ruby
that referenced
this pull request
May 21, 2018
#209 👍 |
tianon
added a commit
to infosiftr/ruby
that referenced
this pull request
May 21, 2018
tianon
added a commit
to infosiftr/ruby
that referenced
this pull request
May 21, 2018
tianon
added a commit
to infosiftr/ruby
that referenced
this pull request
May 22, 2018
tianon
added a commit
to infosiftr/ruby
that referenced
this pull request
May 23, 2018
Good725
added a commit
to Good725/ruby_docker
that referenced
this pull request
Feb 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bundler binstubs are not necessarily generic; they were until bundler 1.16 and should be fixed back, but will likely be non-generic again by default in 2.0
See rubygems/bundler#6469 (comment) for more context.
Fixes #188. Fixes #191. Closes #193.
I have successfully built the following Dockerfiles using this change that fail in the current ruby images: