Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust version #478

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Bump rust version #478

merged 1 commit into from
Oct 28, 2024

Conversation

Earlopain
Copy link
Contributor

The last bump was in 423e364, about 11 months ago.

I have no particular reason for this change except that I feel an update should happen at some point. Every rust version would be excessive but updating it every 6-12 months (or some other cadence) feels appropriate. Could be automated.

Copy link
Member

@tianon tianon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, seems reasonable; thanks!

@tianon tianon merged commit 89946d9 into docker-library:master Oct 28, 2024
26 checks passed
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Oct 28, 2024
Changes:

- docker-library/ruby@89946d9: Merge pull request docker-library/ruby#478 from Earlopain/bump-rust
- docker-library/ruby@e76791f: Bump rust version
- docker-library/ruby@7cb059d: Merge pull request docker-library/ruby#475 from docker-library/jq-IN
- docker-library/ruby@d49362d: Use jq's `IN()` instead of `index()`
docker-library-bot added a commit to docker-library-bot/official-images that referenced this pull request Oct 30, 2024
Changes:

- docker-library/ruby@3df1b04: Update 3.2 to 3.2.6
- docker-library/ruby@89946d9: Merge pull request docker-library/ruby#478 from Earlopain/bump-rust
- docker-library/ruby@e76791f: Bump rust version
- docker-library/ruby@7cb059d: Merge pull request docker-library/ruby#475 from docker-library/jq-IN
- docker-library/ruby@d49362d: Use jq's `IN()` instead of `index()`
Earlopain added a commit to Earlopain/docker-ruby that referenced this pull request Nov 3, 2024
This reverts commit 89946d9, reversing
changes made to 7cb059d.

I chose an inopportune time to do this.

There is an upstream issue where builds on alpine arm64/v8 fail:
https://bugs.ruby-lang.org/issues/20506

Example failure: https://doi-janky.infosiftr.net/job/wip/job/new/job/build-arm64v8/45573/console

I believe rust-lang/rust#131221 will fix this
but it is only slated for Rust 1.83
@Earlopain Earlopain deleted the bump-rust branch November 3, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants