github: annotate build warnings #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crazy-max
force-pushed
the
build-checks-annotations
branch
from
44e2a6e to
aa26ffd
Compare
crazy-max
commented
Jun 14, 2024
This comment was marked as outdated.
This comment was marked as outdated.
crazy-max
force-pushed
the
build-checks-annotations
branch
from
aa26ffd to
0ffd26f
Compare
crazy-max
force-pushed
the
build-checks-annotations
branch
4 times, most recently
from
6d9b5c0 to
653541f
Compare
This comment was marked as outdated.
This comment was marked as outdated.
crazy-max
force-pushed
the
build-checks-annotations
branch
from
f94f0e7 to
f66a1cc
Compare
crazy-max
force-pushed
the
build-checks-annotations
branch
4 times, most recently
from
c311ee7 to
dc41dc9
Compare
This comment was marked as outdated.
This comment was marked as outdated.
crazy-max
commented
Jun 26, 2024
| @@ -15,7 +15,7 @@ on: | |||
|
|
|||
| env: | |||
| NODE_VERSION: "20" | |||
| BUILDX_VERSION: "v0.15.1" | |||
| BUILDX_VERSION: "https://github.com/docker/buildx.git#d8c9ebde1fdcf659f1fa3efa6ccc27a28b0f1564" # https://github.com/docker/buildx/pull/2551 | |||
There was a problem hiding this comment.
needs follow-up to bump to v0.16.0 when released
crazy-max
force-pushed
the
build-checks-annotations
branch
from
dc41dc9 to
ab12e51
Compare
crazy-max
commented
Jun 26, 2024
src/github.ts
Outdated
Comment on lines
344
to
364
| let startLine: number | undefined, endLine: number | undefined; | ||
| for (const range of warning.range ?? []) { | ||
| if (range.start.line && (!startLine || range.start.line < startLine)) { | ||
| startLine = range.start.line; | ||
| } | ||
| if (range.end.line && (!endLine || range.end.line > endLine)) { | ||
| endLine = range.end.line; | ||
| } | ||
| } | ||
| core.info(`${message} --- startLine: ${startLine}, endLine: ${endLine}`); | ||
| core.warning(message, { | ||
| title: title, | ||
| file: source, | ||
| startLine: startLine, | ||
| endLine: endLine | ||
| }); |
There was a problem hiding this comment.
Was looking at showing first and last lines matching warning ranges but GitHub annotations does not seem to display that properly:
core.info returns the right startLine and endLine though:
ConsistentInstructionCasing: Command 'COPy' should match the case of the command majority (lowercase)
More info: https://docs.docker.com/go/dockerfile/rule/consistent-instruction-casing/ --- startLine: 21, endLine: 23
I will just set startLine for now and open a thread on GitHub community.
There was a problem hiding this comment.
crazy-max
force-pushed
the
build-checks-annotations
branch
4 times, most recently
from
42c7667 to
1cee406
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
crazy-max
force-pushed
the
build-checks-annotations
branch
from
1cee406 to
644587f
Compare
tonistiigi
approved these changes
Jun 26, 2024
| let message = atob(warning.short).replace(/\s\(line \d+\)$/, ''); | ||
| if (warning.url) { | ||
| // https://github.com/docker/buildx/blob/d8c9ebde1fdcf659f1fa3efa6ccc27a28b0f1564/commands/build.go#L854 | ||
| message += `\nMore info: ${warning.url}`; |
There was a problem hiding this comment.
Wonder if this link can be made clickable by adding some markdown around it.
There was a problem hiding this comment.
Opened https://github.com/orgs/community/discussions/129897
And does not work with markdown 😞 https://github.com/orgs/community/discussions/129897#discussioncomment-9886696
crazy-max
force-pushed
the
build-checks-annotations
branch
from
1fc5c48 to
644587f
Compare
This was referenced Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
needs buildx(build): resolveWarnings from metadata #362example in this PR through integration tests: https://github.com/docker/actions-toolkit/pull/365/files#diff-cc857d138abc3f09c4d212a933d59584a266fe71521fd2cd87327dc037558a43R17