Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Commit

Permalink
Only test the number of errors
Browse files Browse the repository at this point in the history
The map implementation of go iterates a map random;y so we can't know
which error has what message.

It's ok to remove this here because we have an e2e test (the final
errors are sorted alphabetically).

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
  • Loading branch information
rumpl committed Nov 22, 2019
1 parent 0be3c16 commit 25bc6b4
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions internal/validator/rules/externalsecrets_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,6 @@ func TestExternalSecrets(t *testing.T) {

errs := s.Validate(input)
assert.Equal(t, len(errs), 2)

assert.ErrorContains(t, errs[0], `secret "my_secret" should be external`)
assert.ErrorContains(t, errs[1], `secret "my_other_secret" should be external`)
})

}

0 comments on commit 25bc6b4

Please sign in to comment.