This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvin-lubecki
force-pushed
the
zsh-completion
branch
from
September 6, 2018 08:18
b6709a1
to
4ef6223
Compare
@silvin-lubecki please rebase this |
Yep I'm on it! |
vdemeester
suggested changes
Sep 11, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should hold on to merging that (i.e. the docker/cli
bump) until docker/cli#1361 is merged, it will reduce a lot the number of dependencies
@silvin-lubecki upstream PR merged, can you update vendors once again ? 👼 |
* Update help description and README.md Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
silvin-lubecki
force-pushed
the
zsh-completion
branch
from
September 14, 2018 08:23
4ef6223
to
9b16307
Compare
PTAL @vdemeester |
vdemeester
approved these changes
Sep 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🐸
mnottale
approved these changes
Sep 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Adding the
zsh
shell auto-completion scripts.- How I did it
kubectl
. Default zsh completion generated dynamically bycobra
is not really appealing (it does not complete the flags), so as kubectl, I use thebash
completion scripts with some bootstrap scripts.- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)