Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Correct build instruction for experimental build #447

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

tullo
Copy link
Contributor

@tullo tullo commented Jan 24, 2019

- What I did
Activated experimental features.

- How I did it
sed -i 's/EXPERIMEMTAL/EXPERIMENTAL/' BUILDING.md

- How to verify it
./bin/docker-app version
...
Experimental: on

- Description for the changelog
Correct build instruction for experimental build

Signed-off-by: Andreas Amstutz <andreasamstutz@gmail.com>
Copy link
Member

@chris-crone chris-crone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woops, thanks @tullo, LGTM!

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @tullo for spotting that!

@codecov
Copy link

codecov bot commented Jan 24, 2019

Codecov Report

Merging #447 into master will decrease coverage by 0.21%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #447      +/-   ##
==========================================
- Coverage   62.68%   62.47%   -0.22%     
==========================================
  Files          49       49              
  Lines        2361     2361              
==========================================
- Hits         1480     1475       -5     
- Misses        678      682       +4     
- Partials      203      204       +1
Impacted Files Coverage Δ
types/parameters/parameters.go 85.71% <0%> (-7.94%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3603491...7bb197d. Read the comment docs.

@vdemeester vdemeester merged commit 7ba453c into docker:master Jan 24, 2019
@tullo tullo deleted the building branch January 24, 2019 13:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants