This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
[WIP] Add --digests flag to image ls command to show app image digests #677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jean-Christophe Sirot <jean-christophe.sirot@docker.com>
Codecov Report
@@ Coverage Diff @@
## master #677 +/- ##
=========================================
Coverage ? 70.91%
=========================================
Files ? 56
Lines ? 2912
Branches ? 0
=========================================
Hits ? 2065
Misses ? 582
Partials ? 265
Continue to review full report at Codecov.
|
| return reference.FamiliarName(p.ref) | ||
| }}, | ||
| {"TAG", func(p pkg) string { | ||
| t, ok := p.ref.(reference.Tagged) |
There was a problem hiding this comment.
nit:
if t, ok := p.ref.(reference.Tagged); ok{
return t.Tag()
}| {"APP IMAGE", func(p pkg) string { | ||
| return reference.FamiliarString(p.ref) | ||
| }}, | ||
| {"APP NAME", func(p pkg) string { | ||
| return p.bundle.Name | ||
| }}, | ||
| } | ||
|
|
||
| withDigestColumns = columns{ | ||
| {"REPOSITORY", func(p pkg) string { |
There was a problem hiding this comment.
Why do we have REPOSITORY and TAG here, and not just APP IMAGE and APP NAME ? 🤔
| } | ||
| return "<none>" | ||
| }}, | ||
| {"DIGEST", func(p pkg) string { |
There was a problem hiding this comment.
We're missing a test on that part (with a golden file).
|
superseded by #709 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Add
--digestsflag todocker app image lscommand- How to verify it
the
docker app image ls --digestsshould output a similar message in the console- A picture of a cute animal (not mandatory but encouraged)
