This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Move the inspect command to "image inspect" #699
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #699 +/- ##
==========================================
+ Coverage 71.28% 71.34% +0.05%
==========================================
Files 56 59 +3
Lines 2929 2935 +6
==========================================
+ Hits 2088 2094 +6
Misses 567 567
Partials 274 274
Continue to review full report at Codecov.
|
rumpl
force-pushed
the
feat-refactor
branch
3 times, most recently
from
736983d
to
3891788
Compare
eunomie
reviewed
Oct 17, 2019
| @@ -16,6 +18,15 @@ type inspectOptions struct { | |||
| pretty bool | |||
| } | |||
|
|
|||
| func muteDockerCli(dockerCli command.Cli) func() { | |||
There was a problem hiding this comment.
Shouldn't we make it public instead of duplicating it?
There was a problem hiding this comment.
I had a private conversation with @silvin-lubecki and:
- no idea where to put it
- it will go away soon because we started working on cnab-go to make it take an stdout so that we don't have to mute the cli any more
This is like a reminder for us that we really need to continue working on cnab-go
rumpl
force-pushed
the
feat-refactor
branch
3 times, most recently
from
d566636
to
4f46f9e
Compare
The inspect command needed a bunch of code that was only present in the "internal/commands" package. The patch is big but it's only moving code around: * cnab.go was split into multiple files: * credentials.go -> all things credentials * driver/docker.go -> mainly for the driver.Prepare that all the commands use * registry.go -> has the method to get insecure registries from engine Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
feat-refactor
branch
2 times, most recently
from
a15220a
to
a91eb40
Compare
Cobra makes sure that it's thee Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
ndeloof
approved these changes
Oct 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
The inspect command needed a bunch of code that was only present in the
"internal/commands" package. The patch is big but it's only moving code
around:
- A picture of a cute animal (not mandatory but encouraged)
