This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
Docker app run runs only references #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndeloof
approved these changes
Oct 18, 2019
Codecov Report
@@ Coverage Diff @@
## master #702 +/- ##
=======================================
Coverage 72.71% 72.71%
=======================================
Files 59 59
Lines 3042 3042
=======================================
Hits 2212 2212
Misses 556 556
Partials 274 274Continue to review full report at Codecov.
|
rumpl
force-pushed
the
feat-run-bundle
branch
from
243a28e
to
06c8b36
Compare
eunomie
reviewed
Oct 21, 2019
glours
approved these changes
Oct 21, 2019
silvin-lubecki
suggested changes
Oct 21, 2019
rumpl
force-pushed
the
feat-run-bundle
branch
from
06c8b36
to
5746a0b
Compare
rumpl
force-pushed
the
feat-run-bundle
branch
from
5746a0b
to
c1aef50
Compare
A new flag `--cnab-bundle-json` is added for running a CNAB bundle directly. Otherwise, a built app is ran. Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
rumpl
force-pushed
the
feat-run-bundle
branch
from
c1aef50
to
4158c4b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
A new flag
--cnab-bundle-jsonis added for running a CNAB bundle directly. Otherwise, a built app is ran.- How to verify it
Run
docker app run --cnab-bundle-json e2e/testdata/cnab-without-status/bundle.json.- Description for the changelog
You can run a CNAB bundle with
docker app run --cnab-bundle-json BUNDLE- A picture of a cute animal (not mandatory but encouraged)
