This repository has been archived by the owner on Jun 13, 2021. It is now read-only.
PR followup for add creation to bundles #739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up app image ls tests to remove: - Debug messages - No longer necessary distinct vs total count test for `image ls --quiet`. Addition of the creation date to the bundle ensures that the image ID will always be unique. Signed-off-by: Nick Adcock <nick.adcock@docker.com>
Set the custom payload version to `DockerAppCustomVersionCurrent` when creating a new bundle so as to reduce the number of required changes when developing a new version of the custom payload. Signed-off-by: Nick Adcock <nick.adcock@docker.com>
zappy-shu
changed the title
Codecov Report
@@ Coverage Diff @@
## master #739 +/- ##
=======================================
Coverage 68.85% 68.85%
=======================================
Files 64 64
Lines 3432 3432
=======================================
Hits 2363 2363
Misses 750 750
Partials 319 319Continue to review full report at Codecov.
|
rumpl
approved these changes
Nov 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Set custom payload version to current version number.
Cleaned up app image ls tests.
- How I did it
Set the custom payload version to
DockerAppCustomVersionCurrentwhen creating a new bundle so as to reduce the number of required changes when developing a new version of the custom payload.Cleaned up app image ls tests to remove:
image ls --quiet. Addition of the creation date to the bundle ensures that the image ID will always be unique.- How to verify it
There are no functional changes so the CI tests should cover the verification.
- A picture of a cute animal (not mandatory)
