-
Notifications
You must be signed in to change notification settings - Fork 177
Fix output to have a consistent naming #750
Conversation
@@ -137,7 +137,7 @@ Next, you can check the list of running Apps: | |||
|
|||
```shell | |||
$ docker app ls | |||
INSTALLATION APPLICATION LAST ACTION RESULT CREATED MODIFIED REFERENCE | |||
RUNNING APP APP NAME LAST ACTION RESULT CREATED MODIFIED REFERENCE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if APP NAME
should become APP IMAGE
at some point
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it is actually the app name coming from the metadata, so really this has nothing to do with the name you give to the app image when you build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still unclear to me what this metadata name is for. I can't imagine much scenario where it's anything else but the repository name image is published to.
a8a0176
to
fe1006a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
fe1006a
to
fbdf431
Compare
…nsistent naming Signed-off-by: Caroline Briaud <caroline.briaud@docker.com>
fbdf431
to
3c61975
Compare
Codecov Report
@@ Coverage Diff @@
## master #750 +/- ##
=======================================
Coverage 68.94% 68.94%
=======================================
Files 63 63
Lines 3446 3446
=======================================
Hits 2376 2376
Misses 753 753
Partials 317 317 Continue to review full report at Codecov.
|
Signed-off-by: Caroline Briaud caroline.briaud@docker.com
- What I did
Fix output in docker app image ls and docker app inspect to have a consistent naming
Fix link issue in examples/README.MD
- How to verify it
Run docker app image ls and docker app inspect commands and check outputs
Check link in examples/README.MD
- A picture of a cute animal (not mandatory)