Skip to content
This repository has been archived by the owner on Jun 13, 2021. It is now read-only.

Compose validation #760

Merged
merged 9 commits into from
Nov 28, 2019
Merged

Compose validation #760

merged 9 commits into from
Nov 28, 2019

Commits on Nov 22, 2019

  1. Add external secrets rule 

    Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
    @rumpl
    rumpl committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    4f5d946 View commit details
    Browse the repository at this point in the history

  2. Add relative path rule 

    Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
    @rumpl
    rumpl committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    e1d4364 View commit details
    Browse the repository at this point in the history

  3. Add the validator 

    Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
    @rumpl
    rumpl committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    08c99b7 View commit details
    Browse the repository at this point in the history

  4. Call the validator in packager init and extract 

    Remove the no longer used check for the relative path

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
    @rumpl
    rumpl committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    5d2b833 View commit details
    Browse the repository at this point in the history

  5. Add e2e test for the init with an invalid file 

    Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
    @rumpl
    rumpl committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    fae5df6 View commit details
    Browse the repository at this point in the history

  6. Remove useless check 

    This check is done by the packager now

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
    @rumpl
    rumpl committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    0be3c16 View commit details
    Browse the repository at this point in the history

  7. Only test the number of errors 

    The map implementation of go iterates a map random;y so we can't know
which error has what message.

It's ok to remove this here because we have an e2e test (the final
errors are sorted alphabetically).

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
    @rumpl
    rumpl committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    25bc6b4 View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2019

  1. Change the external secret validation message 

    A secret *must* be external, not *should*

Signed-off-by: Djordje Lukic <lukic.djordje@gmail.com>
    @rumpl
    rumpl committed Nov 23, 2019
    Configuration menu
    Copy the full SHA
    cac8c32 View commit details
    Browse the repository at this point in the history

Commits on Nov 28, 2019

  1. Fix invalid volume definition 

    It can have more than one `:` in its definition.

Signed-off-by: Djordje Lukic <djordje.lukic@docker.com>
    @rumpl
    rumpl committed Nov 28, 2019
    Configuration menu
    Copy the full SHA
    582f377 View commit details
    Browse the repository at this point in the history