-
Notifications
You must be signed in to change notification settings - Fork 177
Warn user if the app bundle version differs with the current app version #769
Warn user if the app bundle version differs with the current app version #769
Conversation
a57ede5
to
76a428f
Compare
Codecov Report
@@ Coverage Diff @@
## master #769 +/- ##
==========================================
- Coverage 72.09% 70.52% -1.57%
==========================================
Files 67 67
Lines 3838 3729 -109
==========================================
- Hits 2767 2630 -137
- Misses 739 756 +17
- Partials 332 343 +11
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but one question about the test between versions and the message we are displaying
if versionPayload, ok := payload.(CustomPayloadAppVersion); ok { | ||
version = versionPayload.AppVersion() | ||
} | ||
if version != internal.Version { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here we are testing the versions are different, not the App Image has been built with a prior version of docker app. Maybe it's what we want, but I think the message should be different in that case, saying that App Image and docker app versions differ.
76a428f
to
7735c7d
Compare
a1ab5ad
to
492d836
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
…rning if it differs on the following commands: - inspect - pull - rm - run - update - image inspect - image render Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
492d836
to
3959df4
Compare
Signed-off-by: Silvin Lubecki <silvin.lubecki@docker.com>
3959df4
to
12e6785
Compare
- What I did
I now check current app version vs bundle app version if any and print a warning if it differs on the following commands:
- How I did it
I stored a new field "app-version" in the bundle's custom payload section, so I can compare built app image with the current app binary version.
- How to verify it
~/.docker/app/bundles/..../bundle.json
), find where the custom payload is and change theapp-version
field- Description for the changelog
- A picture of a cute animal (not mandatory)