Skip to content

Commit

Permalink
progress: remove the experimental label from progress metrics
Browse files Browse the repository at this point in the history
Removes the experimental label from progress metrics. User-metrics
themselves are still experimental so this is still blocked behind the
experimental flag, but this will allow the docker otlp endpoint to
receive these metrics.

Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
  • Loading branch information
jsternberg committed Mar 19, 2024
1 parent 4af0ed5 commit 4999908
Showing 1 changed file with 1 addition and 4 deletions.
5 changes: 1 addition & 4 deletions util/progress/printer.go
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import (
"sync"

"github.com/containerd/console"
"github.com/docker/buildx/util/confutil"
"github.com/docker/buildx/util/logutil"
"github.com/moby/buildkit/client"
"github.com/moby/buildkit/util/progress/progressui"
Expand Down Expand Up @@ -176,9 +175,7 @@ func WithDesc(text string, console string) PrinterOpt {

func WithMetrics(mp metric.MeterProvider, attrs attribute.Set) PrinterOpt {
return func(opt *printerOpts) {
if confutil.IsExperimental() {
opt.mw = newMetrics(mp, attrs)
}
opt.mw = newMetrics(mp, attrs)
}
}

Expand Down

0 comments on commit 4999908

Please sign in to comment.