Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use controller option in bake #1680

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Commits on Mar 15, 2023

  1. controller: refactor build inputs to external struct

    This patch continues the move to attempt to merge the build.Options
    struct into the controllerapi.Options message.
    
    To do this, we extract all the input parameters into a dedicated message
    (adding the missing ones, except for the InStream parameter which will
    require some additional fiddling around). We also rework the
    NamedContexts to allow containing States (by transmitting them as
    DefinitionOps), and adding a Linked field to the common options.
    
    Signed-off-by: Justin Chadwell <me@jedevc.com>
    jedevc committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d8f6d55 View commit details
    Browse the repository at this point in the history
  2. bake: use controller build options as an intermediate stage

    With the previous changes to bring controllerapi.BuildOptions up to date
    with build.Options, we can have bake generate
    controllerapi.BuildOptions, and then convert those to build.Option using
    the controller/build package.
    
    This is an intermediate patch, designed to allow us to clean up some
    shared logic between both build and bake. The next step will be to
    modify bake to use the controller api, and completely skip the
    build.Options generation step.
    
    Signed-off-by: Justin Chadwell <me@jedevc.com>
    jedevc committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d4e38a0 View commit details
    Browse the repository at this point in the history