Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update since buildinfo removal #1681

Merged
merged 1 commit into from
Jul 31, 2023

Conversation

crazy-max
Copy link
Member

@crazy-max crazy-max commented Mar 15, 2023

follow-up moby/buildkit#3582

Update docs since buildinfo has been removed from BuildKit. We need to keep some buildinfo logic in buildx for backward compat with old builders. Such as:

buildx/build/build.go

Lines 559 to 562 in 4a73abf

// inline buildinfo attrs from build arg
if v, ok := opt.BuildArgs["BUILDKIT_INLINE_BUILDINFO_ATTRS"]; ok {
e.Attrs["buildinfo-attrs"] = v
}

Keeping in draft until BuildKit 0.12.

Signed-off-by: CrazyMax <crazy-max@users.noreply.github.com>
@jedevc jedevc mentioned this pull request Mar 29, 2023
@crazy-max crazy-max modified the milestone: v0.11.0 May 23, 2023
@crazy-max crazy-max requested review from jedevc and dvdksn July 31, 2023 08:52
@crazy-max crazy-max marked this pull request as ready for review July 31, 2023 08:52
Copy link
Collaborator

@jedevc jedevc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants