vendor: github.com/containerd/console 8f6c4e4

[crazy-max]

As discussed internally with @milas @laurazard @thaJeztah, the containerd/console terminal check was causing errors to get logged on Windows if the output was redirected (piping to another command with more).

> docker buildx build . | more
failed to get console mode for stdout: The handle is invalid.
failed to get console mode for stdout: The handle is invalid.
[+] Building 0.7s (2/3)                                          docker:default
 => [internal] load build definition from Dockerfile                       0.0s
 => => transferring dockerfile: 4.66kB                                     0.0s
 => resolve image config for docker.io/docker/dockerfile:1                 0.7s
 => [auth] docker/dockerfile:pull token for registry-1.docker.io           0.0s

Bump github.com/containerd/console to containerd/console@8f6c4e4 to include containerd/console#66 that fixes this issue.

[crazy-max]

We could test this with client-side integration tests on Windows related to #2206 (comment)

[thaJeztah]

@crazy-max would github.com/moby/term still be an alternative for this, or is that complicated?

[crazy-max]

@crazy-max would github.com/moby/term still be an alternative for this, or is that complicated?

No because BuildKit progress ui that buildx depends on also uses containerd/console so it still prints one failed to get console mode: https://github.com/moby/buildkit/blob/b09a9f1afef847b71aa01faf1b6ff9c019c75b1f/util/progress/progressui/display.go#L172

[thaJeztah]

Ah, gotcha, thx.

We really need to look at some of these. I have a feeling we have multiple packages / implementations do very similar things

[thaJeztah]

LGTM

left a suggestion (adding a comment to provide context)