-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remote: use winio DialPipeContext for named pipes #2287
Conversation
Just a note: this seems similar to moby/buildkit#4127. If Edit: ignore me, I saw #2286 (not quite sure why it was closed and replaced), and it was a bit clearer. Related but not the same - we explicitly choose to use Future note - could you link between PRs/issues/etc when they're all related to make it a bit easier to navigate between - I hadn't quite realized this was connected to #2250 (comment). |
@iankingori Check the linter error and remove draft if ready. |
5219bcc
to
68fa5c7
Compare
Thanks @jedevc, I'll drop some more context on the next one. I'm creating an issue to track remote driver tests for windows |
68fa5c7
to
6d3ecd8
Compare
The test failure looks like a flake, previous runs passed and only change since was a linting error. |
Signed-off-by: Ian King'ori <kingorim.ian@gmail.com>
6d3ecd8
to
d40c4bb
Compare
Can confirm this fixes the problem I had in #2250 (comment)!! Thanks all! 😄 ❤️ $ ~/git/buildx/buildx.exe --builder windows du
Reclaimable: 0B
Total: 0B |
This PR fixes an issue where the Dialer in go does not support named pipes which the buildkit daemon on Windows uses. I've added a utility DialContext function that uses DialPipeContext for npipe connections on windows.