-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bake: fix output handling for push #2330
Conversation
1a39131
to
cb0e9d9
Compare
Thanks for the quick fixing |
5af9738
to
6538d50
Compare
Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
6538d50
to
47cf4a5
Compare
}`), | ||
} | ||
ctx = context.TODO() | ||
m, _, err = ReadTargets(ctx, []File{fp}, []string{"foo", "bar"}, []string{"*.push=true"}, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we have a similar test already for load ? Or was the behavior different as I can see it uses type=docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't currently have a *.load
override with bake so either v0.12, v0.13 overrides the outputs atm. See me note in PR description about --load
case with bake. I can open a PR with this enhancement so we have a consistent behavior with build
. This was my previous attempt, see 5af9738 but would not be backward compat unfortunately.
fixes #2325
This is a regression from #2302 where override for
--push
was changed to*.output=type=registry
but should be kept with*.push=true
as there is a special handling to only setpush=true
iftype=image
ortype=registry
is already defined for a target. This PR puts back this behavior.The
--load
case is also not properly handled in v0.13.0 as it doesn't append but overrides the outputs (was the same in v0.12). For backward compat, we can keep this behavior for this patch but in follow-up we should handle--load
the same way as--push
.Here is the repro:
v0.12
Output
Output
With this PR
Output
Output
Output