docs: add cross-reference about build secrets #2378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dvdksn
force-pushed
the
docs-crossref-secrets
branch
from
aa4663b
to
e274d21
Compare
crazy-max
reviewed
Apr 3, 2024
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
dvdksn
force-pushed
the
docs-crossref-secrets
branch
from
e274d21
to
e18a2f6
Compare
thaJeztah
reviewed
Apr 3, 2024
Comment on lines
+624
to
+629
| Supported types are: | ||
|
|
||
| - [`file`](#file) | ||
| - [`env`](#env) | ||
|
|
||
| Buildx attempts to detect the `type` automatically if unset. |
There was a problem hiding this comment.
Not a blocker for this PR, but perhaps we could introduce a table for this. Also wondering if type should have an explicit auto option (which would be the default if unset); thinking along these lines;
Perhaps also sort these alphabetically (but looks like the paragraphs aren't either 🙈)
| type | description |
|---|---|
auto (default) |
automatically detect type |
env |
... |
file |
.... |
tonistiigi
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a cross-reference to the build secrets page
Partly addresses #2350