Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add cross-reference about build secrets #2378

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

dvdksn
Copy link
Contributor

@dvdksn dvdksn commented Apr 3, 2024

Adds a cross-reference to the build secrets page

Partly addresses #2350

@dvdksn dvdksn self-assigned this Apr 3, 2024
docs/reference/buildx_build.md Outdated Show resolved Hide resolved
docs/reference/buildx_build.md Outdated Show resolved Hide resolved
Signed-off-by: David Karlsson <35727626+dvdksn@users.noreply.github.com>
Comment on lines +624 to +629
Supported types are:

- [`file`](#file)
- [`env`](#env)

Buildx attempts to detect the `type` automatically if unset.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a blocker for this PR, but perhaps we could introduce a table for this. Also wondering if type should have an explicit auto option (which would be the default if unset); thinking along these lines;

Perhaps also sort these alphabetically (but looks like the paragraphs aren't either 🙈)

type description
auto (default) automatically detect type
env ...
file ....

@crazy-max crazy-max merged commit d805c78 into docker:master Apr 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants