Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: move indirect deps to the right require block #2393

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

crazy-max
Copy link
Member

missed that in #2373

Signed-off-by: CrazyMax <1951866+crazy-max@users.noreply.github.com>
@thaJeztah
Copy link
Member

Still curious if there's a linter for this, or if these should be reported as a bug to the go maintainers. It seems to be happening more in recent Go versions (either dependencies ending in the wrong group, or it adding a new requires groups, and now ending up with 3 or more of them.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazy-max
Copy link
Member Author

Still curious if there's a linter for this, or if these should be reported as a bug to the go maintainers. It seems to be happening more in recent Go versions (either dependencies ending in the wrong group, or it adding a new requires groups, and now ending up with 3 or more of them.

Yes there should be a linter for this 😞. I'm looking at it as follow-up. Not sure if go bug as users might want to organize their go.mod differently in some cases.

@crazy-max crazy-max merged commit 0a3e5e5 into docker:master Apr 9, 2024
67 checks passed
@crazy-max crazy-max deleted the fix-go-mod branch April 9, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants