Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: update to docker 27.1.1 #2621

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

thaJeztah
Copy link
Member

@thaJeztah thaJeztah commented Jul 22, 2024

Also adding a DOCKER_CLI_VERSION build-arg, so that we can set versions
independently for (untagged) pre-releases.

@thaJeztah thaJeztah force-pushed the test_docker_27.1 branch 4 times, most recently from 730d80f to d276fa5 Compare July 22, 2024 12:04
@thaJeztah thaJeztah marked this pull request as ready for review July 22, 2024 12:04
Dockerfile Outdated
@@ -4,7 +4,8 @@ ARG GO_VERSION=1.22
ARG XX_VERSION=1.4.0

# for testing
ARG DOCKER_VERSION=27.0.3
ARG DOCKER_VERSION=27.1.0
ARG DOCKER_CLI_VERSION=${DOCKER_CLI_VERSION-${DOCKER_VERSION}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this is just ARG DOCKER_CLI_VERSION=$DOCKER_VERSION

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh! You're right; not sure what I was thinking there. Let me update; and also update to v27.1.1

Also adding a DOCKER_CLI_VERSION build-arg, so that we can set versions
independently for (untagged) pre-releases.

Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
@thaJeztah thaJeztah self-assigned this Aug 5, 2024
@thaJeztah thaJeztah changed the title Dockerfile: update to docker 27.1.0 Dockerfile: update to docker 27.1.1 Aug 5, 2024
@thaJeztah
Copy link
Member Author

Updated to v27.1.1, and fixed the nit from #2621 (comment)

@crazy-max crazy-max merged commit e2f6808 into docker:master Aug 5, 2024
106 checks passed
@thaJeztah thaJeztah deleted the test_docker_27.1 branch August 5, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants