Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bash completion for network create --scope|--config-only|config-from #248

Merged
merged 1 commit into from
Jul 4, 2017

Conversation

albers
Copy link
Collaborator

@albers albers commented Jun 27, 2017

This adds bash completion for #49.
Ping @sdurrheimer for zsh completion

@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #248 into master will increase coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #248      +/-   ##
==========================================
+ Coverage   48.33%   48.34%   +<.01%     
==========================================
  Files         172      172              
  Lines       11710    11710              
==========================================
+ Hits         5660     5661       +1     
+ Misses       5692     5691       -1     
  Partials      358      358

Copy link
Collaborator

@vdemeester vdemeester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🐮

@thaJeztah thaJeztah added this to the 17.06.1 milestone Jun 30, 2017
@thaJeztah
Copy link
Member

looks like this needs a rebase 😢

…from`

Signed-off-by: Harald Albers <github@albersweb.de>
@albers albers force-pushed the completion-network-create--scope branch from 92293e6 to 22579ba Compare June 30, 2017 09:02
@albers
Copy link
Collaborator Author

albers commented Jun 30, 2017

@thaJeztah rebased

@vieux
Copy link
Contributor

vieux commented Jul 4, 2017

LGTM

@vieux vieux merged commit 3062125 into docker:master Jul 4, 2017
@albers albers deleted the completion-network-create--scope branch July 4, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants