Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shorthand for --tail option #2646

Merged
merged 2 commits into from
Aug 17, 2020
Merged

Add shorthand for --tail option #2646

merged 2 commits into from
Aug 17, 2020

Conversation

horpto
Copy link
Contributor

@horpto horpto commented Jul 23, 2020

I chose -n shorthand as it's similar with linux tail command.

- What I did

- How I did it

- How to verify it

- Description for the changelog

Add shorthand -n for --tail option

- A picture of a cute animal (not mandatory but encouraged)

@codecov-commenter
Copy link

Codecov Report

Merging #2646 into master will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master    #2646   +/-   ##
=======================================
  Coverage   58.13%   58.13%           
=======================================
  Files         295      295           
  Lines       21194    21194           
=======================================
  Hits        12321    12321           
  Misses       7966     7966           
  Partials      907      907           

I chose -n shorthand as it's similar with linux `tail` command.

Signed-off-by: Александр Менщиков <__Singleton__@hackerdom.ru>
@thaJeztah
Copy link
Member

Thanks for contributing ; I'm ok with this change (name is consistent with -n on docker ps), but want to double check with some other maintainers.

Could you also;

Let me know if you need help with that

@horpto horpto requested review from albers and thaJeztah as code owners August 6, 2020 14:26
@horpto horpto force-pushed the patch-1 branch 2 times, most recently from 963e16c to e1a2e16 Compare August 6, 2020 14:35
Signed-off-by: horpto <__Singleton__@hackerdom.ru>
@horpto
Copy link
Contributor Author

horpto commented Aug 6, 2020

@thaJeztah thanks for reply. I found other place with logs.

Copy link
Collaborator

@albers albers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completion LGTM, thanks for the contribution.

Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thank you!

@thaJeztah
Copy link
Member

@cpuguy83 @silvin-lubecki looking good?

Copy link
Contributor

@silvin-lubecki silvin-lubecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @horpto 👍

@thaJeztah
Copy link
Member

Let's get this one merged 👍

@thaJeztah thaJeztah merged commit ca35f29 into docker:master Aug 17, 2020
@thaJeztah thaJeztah added this to the 20.03.0 milestone Aug 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants