[24.0 backport] docs: fix example for proxies in daemon.json #4310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit c846428 added proxies to the example `daemon.json`, based on the implementation that was added in moby/moby@427c7cc. However, a follow-up pull request changed the proxy-configuration in`daemon.json` to nest the configuration in a "proxies" struct, and the documentation was not updated accordingly; see: moby/moby@101dafd This patch fixes the example. Signed-off-by: Sebastiaan van Stijn <github@gone.nl> (cherry picked from commit 2713d0b) Signed-off-by: Sebastiaan van Stijn <github@gone.nl>
dvdksn
approved these changes
May 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commit c846428 (#4199) added proxies to the example
daemon.json, based on the implementation that was added in moby/moby@427c7cc (moby/moby#42835).However, a follow-up pull request changed the proxy-configuration in
daemon.jsonto nest the configuration in a "proxies" struct, and the documentation was not updated accordingly; see: moby/moby@101dafd (moby/moby#43448)This patch fixes the example.
- What I did
- How I did it
- How to verify it
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)